Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/update UUID function to take optional random generator #243

Merged
merged 2 commits into from
Nov 12, 2023
Merged

Feature/update UUID function to take optional random generator #243

merged 2 commits into from
Nov 12, 2023

Conversation

Goutham-AR
Copy link
Contributor

Create RandomGenerator class.
Update uuid function to take in a RandomGenerator class as parameter.
#234

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
include/faker-cxx/String.h 100.00% <100.00%> (ø)
include/faker-cxx/types/RandomGenerator.hpp 100.00% <100.00%> (ø)
src/modules/string/StringTest.cpp 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!

cieslarmichal
cieslarmichal approved these changes Nov 12, 2023
View reviewed changes
Copy link
Owner

@cieslarmichal cieslarmichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for contributing!

@cieslarmichal cieslarmichal merged commit 74c4398 into cieslarmichal:main Nov 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cieslarmichal cieslarmichal cieslarmichal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Goutham-AR @codecov-commenter @cieslarmichal