Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

163 feature/add barcode functionalities to commerce module #221

Conversation

sebastianbacik
Copy link
Contributor

The generated barcode is represented as string in format "12345678". I have run the tests multiple times to be sure everything is working. Please let me know if there is anything that I forgot to add. Sorry for the delay on this issue :)

@codecov-commenter
Copy link

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
src/modules/commerce/CommerceTest.cpp 95.32% <89.79%> (-4.68%) ⬇️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!

Copy link
Owner

@cieslarmichal cieslarmichal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goos job, thanks for contributing 🚀

@cieslarmichal cieslarmichal merged commit fc590e5 into cieslarmichal:main Nov 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants