Feature/hacker #196
Merged
Feature/hacker #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅ ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
📢 Thoughts on this report? Let us know!. |
cieslarmichal
requested changes
Oct 6, 2023
|
I saw that every phrase has a verb, adjective, noun, and an abbreviation. So I checked to see if the phrase had at least one of each of these types of words. The newlines don't appear to be showing in github (when I checked my fork) but I do have them in the code. |
|
Yes I see, good job, github does not show last empty line (if it exists) it shows if it doesnt |
cieslarmichal
approved these changes
Oct 8, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of it works well except for Phrases Test. Should be good enough for production but could use a better idea for testing Phrase.