Use compile options

Signed-off-by: Uilian Ries <[email protected]>
cieslarmichal · May 23, 2024 · c3a1675 · c3a1675
1 parent daf34e7
commit c3a1675
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/.github/workflows/linux-gxx-build.yml b/.github/workflows/linux-gxx-build.yml
@@ -4,7 +4,6 @@ on:
   push:
     branches:
       - 'main'
-      - 'feature/external-deps'
   workflow_dispatch:
   pull_request:
 

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -15,14 +15,6 @@ if (NOT USE_SYSTEM_DEPENDENCIES)
         HAS_STD_FORMAT)
 endif()
 
-if (MSVC)
-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /permissive- /bigobj")
-else ()
-    set(CMAKE_CXX_FLAGS
-        "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic -Wconversion -Wformat -Werror"
-    )
-endif ()
-
 set(LIBRARY_NAME faker-cxx)
 
 set(FAKER_SOURCES
@@ -117,6 +109,11 @@ target_include_directories(
     $<INSTALL_INTERFACE:include>)
 
 target_compile_features(${LIBRARY_NAME} PUBLIC cxx_std_20)
+if (MSVC)
+    target_compile_options(${LIBRARY_NAME} PRIVATE /permissive- /bigobj)
+else ()
+    target_compile_options(${LIBRARY_NAME} PRIVATE -Wall -Wextra -Wpedantic -Wconversion -Wformat -Werror)
+endif ()
 
 install(TARGETS ${LIBRARY_NAME}
     EXPORT ${LIBRARY_NAME}-targets