add korean people names (#289)

cieslarmichal · Nov 20, 2023 · a2a23fc · a2a23fc
1 parent dca806d
commit a2a23fc
Show file tree

Hide file tree

Showing 6 changed files with 262 additions and 5 deletions.
diff --git a/include/faker-cxx/types/Country.h b/include/faker-cxx/types/Country.h
@@ -39,6 +39,7 @@ enum class Country
     Belgium,
     Nederlands,
     China,
+    Korea,
 };
 
 const std::vector<Country> countries{
@@ -47,7 +48,7 @@ const std::vector<Country> countries{
     Country::Turkey, Country::Czech,    Country::Slovakia, Country::Ukraine,     Country::Denmark, Country::Sweden,
     Country::Brazil, Country::Norway,   Country::Japan,    Country::Portugal,    Country::Hungary, Country::Croatia,
     Country::Greece, Country::Slovenia, Country::Austria,  Country::Switzerland, Country::Belgium, Country::Nederlands,
-    Country::China,
+    Country::China,  Country::Korea,
 };
 
 inline std::string toString(Country country)
@@ -68,7 +69,7 @@ inline std::string toString(Country country)
         {Country::Greece, "Greece"},     {Country::Slovenia, "Slovenia"},
         {Country::Austria, "Austria"},   {Country::Switzerland, "Switzerland"},
         {Country::Belgium, "Belgium"},   {Country::Nederlands, "Nederlands"},
-        {Country::China, "China"},
+        {Country::China, "China"},       {Country::Korea, "Korea"},
     };
 
     return countryToStringMapping.at(country);

diff --git a/src/modules/person/Person.cpp b/src/modules/person/Person.cpp
@@ -24,6 +24,7 @@
 #include "data/italy/ItalianPeopleNames.h"
 #include "data/japan/JapanesePeopleNames.h"
 #include "data/JobTitles.h"
+#include "data/korea/KoreanPeopleNames.h"
 #include "data/Languages.h"
 #include "data/Nationalities.h"
 #include "data/nederlands/DutchPeopleNames.h"
@@ -67,7 +68,7 @@ const std::map<Country, PeopleNames> countryToPeopleNamesMapping{
     {Country::Greece, greekPeopleNames},      {Country::Slovenia, slovenianPeopleNames},
     {Country::Austria, austrianPeopleNames},  {Country::Switzerland, swissPeopleNames},
     {Country::Belgium, belgianPeopleNames},   {Country::Nederlands, dutchPeopleNames},
-    {Country::China, chinesePeopleNames},
+    {Country::China, chinesePeopleNames},     {Country::Korea, koreanPeopleNames},
 };
 
 std::string middleNameForCountry(Country country, std::optional<Sex> sex);

diff --git a/src/modules/person/PersonTest.cpp b/src/modules/person/PersonTest.cpp
@@ -23,6 +23,7 @@
 #include "data/italy/ItalianPeopleNames.h"
 #include "data/japan/JapanesePeopleNames.h"
 #include "data/JobTitles.h"
+#include "data/korea/KoreanPeopleNames.h"
 #include "data/Languages.h"
 #include "data/Nationalities.h"
 #include "data/nederlands/DutchPeopleNames.h"
@@ -67,7 +68,7 @@ const std::map<Country, PeopleNames> countryToPeopleNamesMapping{
     {Country::Greece, greekPeopleNames},      {Country::Slovenia, slovenianPeopleNames},
     {Country::Austria, austrianPeopleNames},  {Country::Switzerland, swissPeopleNames},
     {Country::Belgium, belgianPeopleNames},   {Country::Nederlands, dutchPeopleNames},
-    {Country::China, chinesePeopleNames},
+    {Country::China, chinesePeopleNames},     {Country::Korea, koreanPeopleNames},
 };
 
 const std::map<Country, std::string> generatedTestName{
@@ -86,7 +87,7 @@ const std::map<Country, std::string> generatedTestName{
     {Country::Greece, "shouldGenerateGreekName"},      {Country::Slovenia, "shouldGenerateSlovenianName"},
     {Country::Austria, "shouldGenerateAustrianName"},  {Country::Switzerland, "shouldGenerateSwissName"},
     {Country::Belgium, "shouldGenerateBelgianName"},   {Country::Nederlands, "shouldGenerateDutchName"},
-    {Country::China, "shouldGenerateChineseName"},
+    {Country::China, "shouldGenerateChineseName"},     {Country::Korea, "shouldGenerateKoreanName"},
 };
 }