fix leading zeros in numeric string (#228)

cieslarmichal · Nov 10, 2023 · 9ee5465 · 9ee5465
1 parent eeed72b
commit 9ee5465
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/modules/string/String.cpp b/src/modules/string/String.cpp
@@ -148,11 +148,11 @@ std::string String::numeric(unsigned int length, bool allowLeadingZeros)
     {
         if (i == 0 && allowLeadingZeros)
         {
-            alphanumeric += Helper::arrayElement<char>(numericCharactersWithoutZero);
+            alphanumeric += Helper::arrayElement<char>(numericCharacters);
         }
         else
         {
-            alphanumeric += Helper::arrayElement<char>(numericCharacters);
+            alphanumeric += Helper::arrayElement<char>(numericCharactersWithoutZero);
         }
     }
 

diff --git a/src/modules/string/StringTest.cpp b/src/modules/string/StringTest.cpp
@@ -197,7 +197,7 @@ TEST_F(StringTest, shouldGenerateNumericWithoutLeadingZeros)
 {
     const auto numericLength = 13;
 
-    const auto numeric = String::numeric(numericLength, true);
+    const auto numeric = String::numeric(numericLength, false);
 
     const auto nonZeroCharacter = numeric[0];
     const auto numericWithPossibleZeroCharacters = numeric.substr(1);