fix: fix bazel build (#1021)

* fix: fix bazel build * fix: fix bazel build v2
cieslarmichal · Dec 28, 2024 · 4349ae9 · 4349ae9
1 parent ebfc441
commit 4349ae9
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 9 deletions.
diff --git a/.github/workflows/linux-bazel-build.yml b/.github/workflows/linux-bazel-build.yml
@@ -40,16 +40,16 @@ jobs:
             ${{ runner.os }}-
 
       - name: Build faker-cxx library
-        run: bazel build //:faker-cxx
+        run: bazel build //:faker-cxx --enable_workspace
 
       - name: Build faker-cxx examples and run
         run: |
-          bazel build //examples:faker-cxx-basic-example
-          bazel build //examples:faker-cxx-person-example
+          bazel build //examples:faker-cxx-basic-example --enable_workspace
+          bazel build //examples:faker-cxx-person-example --enable_workspace
           bazel-bin/examples/faker-cxx-person-example
           bazel-bin/examples/faker-cxx-basic-example
 
       - name: Build faker-cxx tests and validate
         run: |
-          bazel build //tests:faker-cxx-ut
+          bazel build //tests:faker-cxx-ut --enable_workspace
           bazel-bin/tests/faker-cxx-ut
diff --git a/BUILD.bazel b/BUILD.bazel
@@ -16,10 +16,10 @@ genrule(
     outs = ["include/faker-cxx/version.h"],
     cmd = """
         echo "#pragma once" > $@
-        echo '#define FAKER_CXX_VERSION_MAJOR 2' >> $@
+        echo '#define FAKER_CXX_VERSION_MAJOR 3' >> $@
         echo '#define FAKER_CXX_VERSION_MINOR 0' >> $@
         echo '#define FAKER_CXX_VERSION_PATCH 0' >> $@
-        echo '#define FAKER_CXX_VERSION "2.0.0"' >> $@
+        echo '#define FAKER_CXX_VERSION "3.0.0"' >> $@
     """,
 )
 

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -1,7 +1,7 @@
 cmake_minimum_required(VERSION 3.22)
 project(faker-cxx
         LANGUAGES CXX
-        VERSION 2.0.0
+        VERSION 3.0.0
         DESCRIPTION "C++ Faker library for generating fake (but realistic) data."
         HOMEPAGE_URL "https://github.com/cieslarmichal/faker-cxx")
 

diff --git a/src/modules/internet.cpp b/src/modules/internet.cpp
@@ -418,8 +418,6 @@ unsigned port()
 
 std::string url(const WebProtocol& webProtocol, Locale locale)
 {
-    const auto& internetDefinition = getInternetDefinition(locale);
-
     const auto protocolStr = webProtocol == WebProtocol::Https ? "https" : "http";
 
     return common::format("{}://{}", protocolStr, domainName(locale));