test: weather module

* weather module test case fixed Signed-off-by: Guru Mehar Rachaputi <[email protected]>
cieslarmichal · Sep 27, 2024 · 42ff861 · 42ff861
1 parent 91e8726
commit 42ff861
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 45 deletions.
diff --git a/src/modules/weather.cpp b/src/modules/weather.cpp
@@ -4,38 +4,18 @@
 
 #include "faker-cxx/helper.h"
 #include "weather_data.h"
+#include <span>
 
 namespace faker::weather
 {
 namespace
 {
-const auto& getWeatherDefinition(Locale locale)
+const std::span<const std::string_view> getWeatherDefinition(Locale locale)
 {
     switch (locale)
     {
     case Locale::sv_SE:
         return svSEWeatherDescriptions;
-    case Locale::en_029:
-    case Locale::en_AU:
-    case Locale::en_BW:
-    case Locale::en_BZ:
-    case Locale::en_CA:
-    case Locale::en_cb:
-    case Locale::en_GB:
-    case Locale::en_GH:
-    case Locale::en_HK:
-    case Locale::en_IE:
-    case Locale::en_IN:
-    case Locale::en_JM:
-    case Locale::en_MT:
-    case Locale::en_MY:
-    case Locale::en_NZ:
-    case Locale::en_PH:
-    case Locale::en_SG:
-    case Locale::en_TT:
-    case Locale::en_US:
-    case Locale::en_ZA:
-    case Locale::en_ZW:
     default:
         return enUSWeatherDescriptions;
     }

diff --git a/tests/modules/weather_test.cpp b/tests/modules/weather_test.cpp
@@ -6,39 +6,20 @@
 #include "faker-cxx/types/locale.h"
 #include "faker-cxx/weather.h"
 #include "weather_data.h"
+#include <span>
 
 using namespace ::testing;
+using namespace faker;
 using namespace faker::weather;
 
 namespace
 {
-const auto& getWeatherDefinition(Locale locale)
+const std::span<const std::string_view> getWeatherDefinition(Locale locale)
 {
     switch (locale)
     {
     case Locale::sv_SE:
         return svSEWeatherDescriptions;
-    case Locale::en_029:
-    case Locale::en_AU:
-    case Locale::en_BW:
-    case Locale::en_BZ:
-    case Locale::en_CA:
-    case Locale::en_cb:
-    case Locale::en_GB:
-    case Locale::en_GH:
-    case Locale::en_HK:
-    case Locale::en_IE:
-    case Locale::en_IN:
-    case Locale::en_JM:
-    case Locale::en_MT:
-    case Locale::en_MY:
-    case Locale::en_NZ:
-    case Locale::en_PH:
-    case Locale::en_SG:
-    case Locale::en_TT:
-    case Locale::en_US:
-    case Locale::en_ZA:
-    case Locale::en_ZW:
     default:
         return enUSWeatherDescriptions;
     }
@@ -50,7 +31,7 @@ class WeatherTest : public TestWithParam<Locale>
 public:
 };
 
-TEST_F(WeatherTest, shouldGenerateWeatherDescription)
+TEST_P(WeatherTest, shouldGenerateWeatherDescription)
 {
 
     const auto locale = GetParam();