Feature/moon celestial #1655
Open
Feature/moon celestial #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThatRedox
reviewed
Oct 26, 2023
chunky/src/java/se/llbit/chunky/renderer/scene/sky/CelestialBodyType.java
Outdated
Show resolved
Hide resolved
|
This needs a rebase after the recent refactorings. |
ShirleyNekoDev
force-pushed
the
feature/moon-celestial
branch
from
ea26ffe
to
062f909
Compare
|
Should be ready now :)
|
|
Do we need to reset the moon texture after reloading the resource packs? wouldn't it be better to have a MoonPhaseTextureLoader that handles this? |
Yeah, probably a good idea to refresh the moon texture after a resource pack reload! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logic for different sun textures (moon / custom) including moon phases.
Only in code at the moment including loading/saving into scene config, UI can be added later.
This was recently requested in Discord and in previous issues (#1208, #731).
based on top of #1654 (diff is way smaller)