add more edge cases for URLs #166
Conversation
chucker
commented
Oct 16, 2023
•
chucker
commented
- '+' in the path
- '@' for user names
'+' in a URL works; '@' for user names does not
| "(?<port>\\d+))?(?<path>/[^#?]*)?(?<query>\\?" | ||
| "((?<userColon>:)(?<password>\\w+))?(?<at>@))?" | ||
| "(?<host>[^:/]+)((?<portColon>:)(?<port>\\d+))?" | ||
| "(?<path>/[^#?]*)?(?<query>\\?" |
There was a problem hiding this comment.
If the @ symbol is on its own (which is allowed by this regex), it is included in the host:
Is this intended?
There was a problem hiding this comment.
Link to test: https://regex101.com/r/n7KVRu/1
There was a problem hiding this comment.
This (?<host>[^:\/]+) implicitly allows any characters. Maybe this should be constrained to alphanumerics (i.e. (?<host>[a-zA-Z0-9-.]+))?
There was a problem hiding this comment.
I believe this doesn’t matter, because the host is later on (in the loop) restricted to [NSCharacterSet URLHostAllowedCharacterSet].
There was a problem hiding this comment.
Link to test
I've made the user group optional in the regex, and if not set, 8e32b64 will now remove the @ altogether. Added another test for this.
There was a problem hiding this comment.
you may want to make group 3 a non-capturing group
There was a problem hiding this comment.
I have used this one in one of my projects, in case you want to look at another approach: https://regex101.com/r/bsN8uj/5
|
Hmm, what about IDNs? Sigh. |
