Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Update chroma-load to only output errors to stdout. #3338

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

rescrv
Copy link
Contributor

@rescrv rescrv commented Dec 19, 2024

The sheer volume of output requires more CPU for a terminal to render
than chroma-load consumes (kiB written per query). I'm betting it's a
good approximation for what's happening in production.

The sheer volume of output requires more CPU for a terminal to render
than chroma-load consumes (kiB written per query).  I'm betting it's a
good approximation for what's happening in production.
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@rescrv rescrv merged commit 689f3c9 into main Dec 19, 2024
78 checks passed
@rescrv rescrv deleted the rescrv/load-errors-only branch December 19, 2024 17:38
Copy link
Contributor

@eculver eculver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants