[ENH] Implement rank() for blockfile #3331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1 task
sanketkedia
reviewed
Dec 20, 2024
| @@ -657,6 +657,54 @@ impl<'me, K: ArrowReadableKey<'me> + Into<KeyWrapper>, V: ArrowReadableValue<'me | |||
| self.root.id | |||
| } | |||
|
|
|||
| pub(crate) async fn rank( | |||
There was a problem hiding this comment.
Please add a comment here as to what this function does
sanketkedia
reviewed
Dec 20, 2024
| Err(e) | ||
| } | ||
| } | ||
| pub(crate) fn get_offset_stream<'me>( |
There was a problem hiding this comment.
Add a comment on the contract of this method. It's not clear from the names
There was a problem hiding this comment.
Added comments
sanketkedia
approved these changes
Dec 20, 2024
Sicheng-Pan
force-pushed
the
12-18-_enh_implement_rank_for_blockfile
branch
from
c6192f7 to
5c09493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
rank(prefix, key)method for blockfile, which calculates the number of elements in the blockfile that is strictly less than the given prefix-key pair. In otherword, the given prefix-key pair can be inserted at its rank without breaking the order of the blockfile.rank(prefix, key)method to replaceget_at_index(index)inLimitOperatorandRecordSegmentReader.Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?