Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLN] Deprecate PullLogsOperator #3281

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

Sicheng-Pan
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan commented Dec 10, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Replace PullLogsOperator with FetchLogOperator
  • New functionality
    • N/A

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
N/A

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor Author

Sicheng-Pan commented Dec 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sicheng-Pan Sicheng-Pan marked this pull request as ready for review December 10, 2024 20:14
@Sicheng-Pan Sicheng-Pan force-pushed the 12-10-_cln_deprecate_pulllogsoperator branch from 8877c7c to a1a2106 Compare December 11, 2024 18:50
@Sicheng-Pan Sicheng-Pan force-pushed the 12-10-_cln_cleanup_query_node_after_pushdown branch from e800d7e to 8147711 Compare December 11, 2024 19:33
@Sicheng-Pan Sicheng-Pan force-pushed the 12-10-_cln_deprecate_pulllogsoperator branch from a1a2106 to 85636e3 Compare December 11, 2024 19:33
Copy link
Contributor Author

Sicheng-Pan commented Dec 11, 2024

Merge activity

  • Dec 11, 3:21 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 11, 3:27 PM EST: Graphite rebased this pull request as part of a merge.
  • Dec 11, 3:29 PM EST: A user merged this pull request with Graphite.

@Sicheng-Pan Sicheng-Pan changed the base branch from 12-10-_cln_cleanup_query_node_after_pushdown to graphite-base/3281 December 11, 2024 20:23
@Sicheng-Pan Sicheng-Pan changed the base branch from graphite-base/3281 to main December 11, 2024 20:25
@Sicheng-Pan Sicheng-Pan force-pushed the 12-10-_cln_deprecate_pulllogsoperator branch from 3c0e375 to e3bfa80 Compare December 11, 2024 20:26
@Sicheng-Pan Sicheng-Pan merged commit 04c602b into main Dec 11, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants