-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLN] Deprecate PullLogsOperator #3281
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1 task
Sicheng-Pan
force-pushed
the
12-10-_cln_deprecate_pulllogsoperator
branch
from
December 11, 2024 18:50
8877c7c
to
a1a2106
Compare
Sicheng-Pan
force-pushed
the
12-10-_cln_cleanup_query_node_after_pushdown
branch
from
December 11, 2024 19:33
e800d7e
to
8147711
Compare
Sicheng-Pan
force-pushed
the
12-10-_cln_deprecate_pulllogsoperator
branch
from
December 11, 2024 19:33
a1a2106
to
85636e3
Compare
codetheweb
approved these changes
Dec 11, 2024
Sicheng-Pan
changed the base branch from
12-10-_cln_cleanup_query_node_after_pushdown
to
graphite-base/3281
December 11, 2024 20:23
Sicheng-Pan
force-pushed
the
12-10-_cln_deprecate_pulllogsoperator
branch
from
December 11, 2024 20:26
3c0e375
to
e3bfa80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
PullLogsOperator
withFetchLogOperator
Test plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?
N/A