Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Add headers to async client requests #3236

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

drewkim
Copy link
Contributor

@drewkim drewkim commented Dec 3, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Fixes bug where headers were not being added to async client requests. Also adds the verify argument.
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Copy link

github-actions bot commented Dec 3, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor Author

drewkim commented Dec 3, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@drewkim drewkim requested a review from HammadB December 3, 2024 21:15
@drewkim drewkim requested a review from codetheweb December 3, 2024 22:11
Copy link
Contributor

@codetheweb codetheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you may want to move this logic to where the httpx client is created on line 109 (inside _get_client()) similar to how the sync client works. I also just realized looking at the code that the chroma_server_ssl_verify setting seems to be ignored, so we should also fix that.

@drewkim drewkim marked this pull request as ready for review December 3, 2024 22:56
@drewkim drewkim requested a review from codetheweb December 3, 2024 22:56
@drewkim drewkim merged commit 22e7f84 into main Dec 3, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants