Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHORE] To the workspace with shared deps. #3224

Merged
merged 1 commit into from
Dec 3, 2024
Merged

[CHORE] To the workspace with shared deps. #3224

merged 1 commit into from
Dec 3, 2024

Conversation

rescrv
Copy link
Contributor

@rescrv rescrv commented Dec 2, 2024

This PR moves to the workspace's Cargo.toml any package used by both
chroma_load and another package. It also drops patch version for easier
upgrades.

Copy link

github-actions bot commented Dec 2, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@rescrv rescrv requested a review from Sicheng-Pan December 2, 2024 21:09
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Base automatically changed from rescrv/load5 to rescrv/load4 December 3, 2024 16:21
Base automatically changed from rescrv/load4 to main December 3, 2024 19:15
This PR moves to the workspace's Cargo.toml any package used by both
chroma_load and another package.  It also drops patch version for easier
upgrades.
@rescrv rescrv merged commit c199996 into main Dec 3, 2024
71 checks passed
@rescrv rescrv deleted the rescrv/load6 branch December 3, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants