Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: replace get_* methods on memory blockfile impl with get_range() #2935

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented Oct 11, 2024

Description of changes

Replaces specialized methods like get_gt and get_lt with a single get_range() method that behaves similarly to the std BTreeMap::range() method. This reduces complexity/repetition and also enables queries that are bounded in both directions.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@codetheweb codetheweb force-pushed the feat-arrow-block-range-api branch from 7c5996d to 353d385 Compare October 11, 2024 22:48
@codetheweb codetheweb force-pushed the feat-memory-block-range-api branch from 80f9cec to e9f81d0 Compare October 11, 2024 22:48
@codetheweb codetheweb force-pushed the feat-arrow-block-range-api branch from 353d385 to f47cbdb Compare October 16, 2024 17:57
@codetheweb codetheweb force-pushed the feat-memory-block-range-api branch from e9f81d0 to 483d11d Compare October 16, 2024 17:57
@codetheweb codetheweb force-pushed the feat-arrow-block-range-api branch from f47cbdb to 03d6324 Compare October 16, 2024 18:28
@codetheweb codetheweb force-pushed the feat-memory-block-range-api branch from 483d11d to 44f4425 Compare October 16, 2024 18:28
@codetheweb codetheweb marked this pull request as ready for review October 16, 2024 18:43
@codetheweb codetheweb force-pushed the feat-arrow-block-range-api branch from 03d6324 to 00058c2 Compare October 16, 2024 19:03
@codetheweb codetheweb force-pushed the feat-memory-block-range-api branch from 44f4425 to d5c351c Compare October 16, 2024 19:03
@codetheweb codetheweb force-pushed the feat-arrow-block-range-api branch from 2652357 to db61125 Compare October 18, 2024 17:16
@codetheweb codetheweb force-pushed the feat-memory-block-range-api branch from d5c351c to 70d4eb0 Compare October 18, 2024 17:17
@codetheweb codetheweb force-pushed the feat-arrow-block-range-api branch from d72cd6e to c665051 Compare October 25, 2024 23:33
@codetheweb codetheweb force-pushed the feat-memory-block-range-api branch from 70d4eb0 to 101053b Compare October 25, 2024 23:33
@codetheweb codetheweb force-pushed the feat-arrow-block-range-api branch from c665051 to a219e15 Compare October 29, 2024 16:54
@codetheweb codetheweb force-pushed the feat-memory-block-range-api branch from 101053b to a6b8af4 Compare October 29, 2024 16:54
Copy link
Contributor Author

codetheweb commented Nov 4, 2024

Merge activity

  • Nov 4, 1:28 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 4, 1:35 PM EST: Graphite rebased this pull request as part of a merge.
  • Nov 4, 1:36 PM EST: A user merged this pull request with Graphite.

@codetheweb codetheweb changed the base branch from feat-arrow-block-range-api to graphite-base/2935 November 4, 2024 18:31
@codetheweb codetheweb changed the base branch from graphite-base/2935 to main November 4, 2024 18:33
@codetheweb codetheweb force-pushed the feat-memory-block-range-api branch from a6b8af4 to 1fa8347 Compare November 4, 2024 18:34
@codetheweb codetheweb merged commit ba09fa4 into main Nov 4, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants