-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH]: replace get_*
methods on memory blockfile impl with get_range()
#2935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @codetheweb and the rest of your teammates on Graphite |
1 task
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
1 task
codetheweb
force-pushed
the
feat-arrow-block-range-api
branch
from
October 11, 2024 22:48
7c5996d
to
353d385
Compare
codetheweb
force-pushed
the
feat-memory-block-range-api
branch
from
October 11, 2024 22:48
80f9cec
to
e9f81d0
Compare
codetheweb
force-pushed
the
feat-arrow-block-range-api
branch
from
October 16, 2024 17:57
353d385
to
f47cbdb
Compare
codetheweb
force-pushed
the
feat-memory-block-range-api
branch
from
October 16, 2024 17:57
e9f81d0
to
483d11d
Compare
codetheweb
force-pushed
the
feat-arrow-block-range-api
branch
from
October 16, 2024 18:28
f47cbdb
to
03d6324
Compare
codetheweb
force-pushed
the
feat-memory-block-range-api
branch
from
October 16, 2024 18:28
483d11d
to
44f4425
Compare
codetheweb
force-pushed
the
feat-arrow-block-range-api
branch
from
October 16, 2024 19:03
03d6324
to
00058c2
Compare
codetheweb
force-pushed
the
feat-memory-block-range-api
branch
from
October 16, 2024 19:03
44f4425
to
d5c351c
Compare
codetheweb
force-pushed
the
feat-arrow-block-range-api
branch
from
October 18, 2024 17:16
2652357
to
db61125
Compare
codetheweb
force-pushed
the
feat-memory-block-range-api
branch
from
October 18, 2024 17:17
d5c351c
to
70d4eb0
Compare
codetheweb
force-pushed
the
feat-arrow-block-range-api
branch
from
October 25, 2024 23:33
d72cd6e
to
c665051
Compare
codetheweb
force-pushed
the
feat-memory-block-range-api
branch
from
October 25, 2024 23:33
70d4eb0
to
101053b
Compare
1 task
sanketkedia
approved these changes
Oct 29, 2024
codetheweb
force-pushed
the
feat-arrow-block-range-api
branch
from
October 29, 2024 16:54
c665051
to
a219e15
Compare
codetheweb
force-pushed
the
feat-memory-block-range-api
branch
from
October 29, 2024 16:54
101053b
to
a6b8af4
Compare
codetheweb
changed the base branch from
feat-arrow-block-range-api
to
graphite-base/2935
November 4, 2024 18:31
codetheweb
force-pushed
the
feat-memory-block-range-api
branch
from
November 4, 2024 18:34
a6b8af4
to
1fa8347
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Replaces specialized methods like get_gt and get_lt with a single get_range() method that behaves similarly to the std BTreeMap::range() method. This reduces complexity/repetition and also enables queries that are bounded in both directions.
Test plan
How are these changes tested?
pytest
for python,yarn test
for js,cargo test
for rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?