[ENH] Add otel support for query and compaction service #2122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
|
Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas |
sanketkedia
changed the title
HammadB
reviewed
May 2, 2024
rust/worker/chroma_config.yaml
Outdated
| @@ -4,6 +4,8 @@ | |||
| # for now we nest it in the worker directory | |||
|
|
|||
| query_service: | |||
| svc_name: "query-service" | |||
beggers
approved these changes
May 2, 2024
sanketkedia
force-pushed
the
add_otel_support
branch
from
f692b18 to
8b7507a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Export traces and spans in open telemetry format so that it can be consumed by backends like Jaeger and Honeycomb. For Jaeger verified that it works locally. Need to test honeycomb
Test plan
All existing tests pass. Verified locally via tilt up and tilt down that traces are exported to Jaeger
Documentation Changes
NA