Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [TST] Multitenancy bug fix #1276

Merged
merged 25 commits into from
Oct 24, 2023
Merged

[BUG] [TST] Multitenancy bug fix #1276

merged 25 commits into from
Oct 24, 2023

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Oct 24, 2023

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
  • New functionality
    • None.

Test plan

How are these changes tested?
These are test changes.

  • Tests pass locally with pytest for python, yarn test for js

Documentation Changes

None required.

@HammadB HammadB changed the title [BUG] [TST} Multitenancy bug fix [BUG] [TST] Multitenancy bug fix Oct 24, 2023
@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)

@HammadB
Copy link
Collaborator Author

HammadB commented Oct 24, 2023

Commit history got ruined...

@HammadB HammadB merged commit 0b0b785 into main Oct 24, 2023
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants