Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinator with Database as the System Catalog #1274

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

Ishiihara
Copy link
Contributor

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • ...
  • New functionality
    • Enhance the go coordinator to use database as the system catalog

Test plan

How are these changes tested?

  • test_systems.py
  • Example and property based test in the go coordinator

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)

@Ishiihara Ishiihara force-pushed the coordinator_table_catalog branch 4 times, most recently from 1689847 to f9a5076 Compare October 24, 2023 16:39
Copy link
Collaborator

@HammadB HammadB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add comments on the core class

@Ishiihara Ishiihara force-pushed the coordinator_table_catalog branch 2 times, most recently from 3d726c4 to 6d128a9 Compare October 25, 2023 00:10
@Ishiihara Ishiihara force-pushed the coordinator_table_catalog branch 2 times, most recently from eeecb89 to 7e84315 Compare October 25, 2023 00:19
Copy link
Collaborator

@HammadB HammadB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. Please address remaining comments before merge. Thanks!

@Ishiihara Ishiihara force-pushed the coordinator_table_catalog branch from 7e84315 to 21f715a Compare October 25, 2023 05:24
@Ishiihara Ishiihara merged commit ee1c364 into chroma-core:main Oct 25, 2023
83 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants