[CLN] Remove support for 3.7, add support for 3.11 #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
1 task
beggers
approved these changes
Oct 23, 2023
HammadB
added a commit
that referenced
this pull request
Oct 24, 2023
## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - ... - New functionality - Adds multitenancy and databases as first class concepts by migrating the db and plumbing it through the API into the sysdb - We now treat the "System" as a singleton-per-path and create a wrapper API object that proxies to it with context on the tenant/database. In this way the server is context-unaware about the connection. ## Test plan *How are these changes tested?* Unit Tests were added for new client tenant/database behavior Property tests were added for the new tenant/database behavior by subclassing the collection state machine and switching the tenant/database as a state machine transition. - [ ] Tests pass locally with `pytest` for python, `yarn test` for js ## Documentation Changes I will add a section to the docs about multitenancy and how to use it. We can remove warnings about the client being a singleton.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
Existing tests across supported versions
pytestfor python,yarn testfor jsDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?