Skip to content

Commit

Permalink
[BUG] GRPC Metadata segment should return results (#2073)
Browse files Browse the repository at this point in the history
## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
- Fixes a bug where the segment was returning an empty [] despite
constructing the correct result
 - New functionality
	 - None

## Test plan
*How are these changes tested?*
We should have a test for this! For now I am getting the bug fix up and
we can discuss how to test.
- [!!!!] Tests pass locally with `pytest` for python, `yarn test` for
js, `cargo test` for rust

## Documentation Changes
None
  • Loading branch information
HammadB authored Apr 29, 2024
1 parent bb7863a commit f42567e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion chromadb/segment/impl/metadata/grpc_segment.py
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def get_metadata(
result = self._from_proto(record)
results.append(result)

return []
return results

def _where_to_proto(self, where: Optional[Where]) -> pb.Where:
response = pb.Where()
Expand Down

0 comments on commit f42567e

Please sign in to comment.