Skip to content

Commit

Permalink
[BUG] Double comparison proto conversion (#2074)
Browse files Browse the repository at this point in the history
Not sure if this is correct but type checker was complaining so putting
up for thoughts

## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
	 - Fixes a (assumed) bug where we were converting the wrong type
 - New functionality
	 - None

## Test plan
*How are these changes tested?*
We should to discuss the testing here / why this worked
- [!!!] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

## Documentation Changes
None
  • Loading branch information
HammadB authored Apr 29, 2024
1 parent 81d97dd commit 773556f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion chromadb/segment/impl/metadata/grpc_segment.py
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ def _where_to_proto(self, where: Optional[Where]) -> pb.Where:
sfc = pb.SingleDoubleComparison()
sfc.value = operand
sfc.generic_comparator = pb.GenericComparator.EQ
dc.double_list_operand.CopyFrom(sfc)
dc.single_double_operand.CopyFrom(sfc)

response.direct_comparison.CopyFrom(dc)
return response
Expand Down

0 comments on commit 773556f

Please sign in to comment.