Skip to content

Commit

Permalink
[ENH] Pass env into helm for query/compaction services (#2094)
Browse files Browse the repository at this point in the history
## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
	 -Pass env into helm for query/compaction services
 - New functionality
	 - None

## Test plan
*How are these changes tested?*
- [x] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

## Documentation Changes
None
  • Loading branch information
HammadB authored May 1, 2024
1 parent e6c35a0 commit 57fcbcd
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 0 deletions.
2 changes: 2 additions & 0 deletions k8s/distributed-chroma/templates/compaction-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,12 @@ spec:
ports:
- containerPort: 50051
env:
{{ range .Values.compactionService.env }}
- name: CHROMA_COMPACTION_SERVICE__MY_IP
valueFrom:
fieldRef:
fieldPath: status.podIP
{{ end }}
topologySpreadConstraints:
- maxSkew: 1
topologyKey: "kubernetes.io/hostname"
Expand Down
2 changes: 2 additions & 0 deletions k8s/distributed-chroma/templates/query-service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,12 @@ spec:
- name: chroma
mountPath: /index_data
env:
{{ range .Values.queryService.env }}
- name: CHROMA_QUERY_SERVICE__MY_IP
valueFrom:
fieldRef:
fieldPath: status.podIP
{{ end }}
topologySpreadConstraints:
- maxSkew: 1
topologyKey: "kubernetes.io/hostname"
Expand Down
2 changes: 2 additions & 0 deletions k8s/distributed-chroma/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,13 @@ queryService:
image:
repository: 'local'
tag: 'query-service'
env:

compactionService:
image:
repository: 'local'
tag: 'compaction-service'
env:

sysdbMigration:
image:
Expand Down

0 comments on commit 57fcbcd

Please sign in to comment.