Skip to content

Commit

Permalink
[BUG][TST] Fix bug in tenant state machine test (#1290)
Browse files Browse the repository at this point in the history
## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
- Fixes a small bug in the tenant/collections state machine to reference
the model, not the collection object, since the collection object should
only be name placeholder.
 - New functionality
	 - None

## Test plan
*How are these changes tested?*
These are tests.
- [x] Tests pass locally with `pytest` for python, `yarn test` for js

## Documentation Changes
None required.
  • Loading branch information
HammadB authored Oct 25, 2023
1 parent c53c6eb commit 3990ead
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion chromadb/test/property/test_collections.py
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,8 @@ def modify_coll(
c.modify(metadata=new_metadata, name=new_name)
return multiple()

self.set_model(new_name, self.model[coll.name])
self.delete_from_model(coll.name)
self.set_model(new_name, coll.metadata)
coll.name = new_name

c.modify(metadata=new_metadata, name=new_name)
Expand Down

0 comments on commit 3990ead

Please sign in to comment.