Skip to content

Commit

Permalink
[CLN] Remove prints and add documentation
Browse files Browse the repository at this point in the history
  • Loading branch information
beggers committed Feb 24, 2024
1 parent fd14f2d commit 3742499
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
8 changes: 8 additions & 0 deletions chromadb/test/property/strategies.py
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,10 @@ def embedding_function_strategy(
class ExternalCollection:
"""
An external view of a collection.
This strategy only contains information about a collection that a client of Chroma
sees -- that is, it contains none of Chroma's internal bookkeeping. It should
be used to test the API and client code.
"""
name: str
metadata: Optional[types.Metadata]
Expand All @@ -249,6 +253,10 @@ class ExternalCollection:
class Collection(ExternalCollection):
"""
An internal view of a collection.
This strategy contains all the information Chroma uses internally to manage a
collection. It is a superset of ExternalCollection and should be used to test
internal Chroma logic.
"""
id: uuid.UUID
dimension: int
Expand Down
4 changes: 0 additions & 4 deletions chromadb/test/property/test_collections.py
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,6 @@ def modify_coll(
return multiple()

c = self.api.get_collection(name=coll.name)
print("before API:", c)
print("model:", self.model)
_metadata: Optional[Mapping[str, Any]] = self.model[coll.name]
_name: str = coll.name
if new_metadata is not None:
Expand Down Expand Up @@ -228,8 +226,6 @@ def modify_coll(
self.set_model(_name, _metadata)
c.modify(metadata=_metadata, name=_name)
c = self.api.get_collection(name=coll.name)
print("after API:", c)
print("model:", self.model)

assert c.name == coll.name
assert c.metadata == self.model[coll.name]
Expand Down

0 comments on commit 3742499

Please sign in to comment.