Linter

rust/blockstore/src/arrow/blockfile.rs

@@ -699,7 +699,7 @@ impl<'me, K: ArrowReadableKey<'me> + Into<KeyWrapper>, V: ArrowReadableValue<'me
 
             result.extend(block.get_all_data());
         }
-        return result;
+        result
     }
 }
 

rust/blockstore/src/memory/storage.rs

@@ -586,11 +586,11 @@ impl Writeable for &DataRecord<'_> {
 }
 
 impl Writeable for &SpannPostingList<'_> {
-    fn write_to_storage(prefix: &str, key: KeyWrapper, value: Self, storage: &StorageBuilder) {
+    fn write_to_storage(_: &str, _: KeyWrapper, _: Self, _: &StorageBuilder) {
         todo!()
     }
 
-    fn remove_from_storage(prefix: &str, key: KeyWrapper, storage: &StorageBuilder) {
+    fn remove_from_storage(_: &str, _: KeyWrapper, _: &StorageBuilder) {
         todo!()
     }
 }

rust/blockstore/src/types/reader.rs

@@ -134,7 +134,7 @@ impl<
 
     pub async fn get_all_data(&'referred_data self) -> Vec<(&'referred_data str, K, V)> {
         match self {
-            BlockfileReader::MemoryBlockfileReader(reader) => todo!(),
+            BlockfileReader::MemoryBlockfileReader(_) => todo!(),
             BlockfileReader::ArrowBlockfileReader(reader) => reader.get_all_data().await,
         }
     }

rust/index/src/hnsw.rs

@@ -1,6 +1,5 @@
 use super::{Index, IndexConfig, IndexUuid, PersistentIndex};
 use chroma_error::{ChromaError, ErrorCodes};
-use chroma_types::MetadataValueConversionError;
 use std::ffi::CString;
 use std::ffi::{c_char, c_int};
 use std::path::Path;

rust/index/src/lib.rs

@@ -13,6 +13,7 @@ use chroma_cache::new_non_persistent_cache_for_test;
 use chroma_storage::test_storage;
 pub use hnsw::*;
 use hnsw_provider::HnswIndexProvider;
+#[allow(unused_imports)]
 pub use spann::*;
 use tempfile::tempdir;
 pub use types::*;

rust/index/src/spann/types.rs

@@ -1,6 +1,5 @@
 use std::collections::HashMap;
 
-use arrow::error;
 use chroma_blockstore::{provider::BlockfileProvider, BlockfileWriter, BlockfileWriterOptions};
 use chroma_distance::DistanceFunction;
 use chroma_error::{ChromaError, ErrorCodes};
@@ -14,6 +13,7 @@ use crate::{
 };
 
 // TODO(Sanket): Add locking structures as necessary.
+#[allow(dead_code)]
 pub struct SpannIndexWriter {
     // HNSW index and its provider for centroid search.
     hnsw_index: HnswIndexRef,
@@ -125,7 +125,7 @@ impl SpannIndexWriter {
     ) -> Result<BlockfileWriter, SpannIndexWriterConstructionError> {
         let mut bf_options = BlockfileWriterOptions::new();
         bf_options = bf_options.unordered_mutations();
-        bf_options = bf_options.fork(blockfile_id.clone());
+        bf_options = bf_options.fork(*blockfile_id);
         match blockfile_provider
             .write::<u32, &SpannPostingList<'_>>(bf_options)
             .await

rust/index/src/types.rs

@@ -1,6 +1,5 @@
-use chroma_distance::{DistanceFunction, DistanceFunctionError};
-use chroma_error::{ChromaError, ErrorCodes};
-use thiserror::Error;
+use chroma_distance::DistanceFunction;
+use chroma_error::ChromaError;
 use uuid::Uuid;
 
 #[derive(Clone, Debug)]

rust/worker/src/segment/distributed_hnsw_segment.rs

@@ -4,16 +4,15 @@ use super::record_segment::ApplyMaterializedLogError;
 use super::utils::hnsw_params_from_segment;
 use super::{SegmentFlusher, SegmentWriter};
 use async_trait::async_trait;
-use chroma_distance::{DistanceFunction, DistanceFunctionError};
+use chroma_distance::DistanceFunctionError;
 use chroma_error::{ChromaError, ErrorCodes};
 use chroma_index::hnsw_provider::{
     HnswIndexProvider, HnswIndexProviderCreateError, HnswIndexProviderForkError,
     HnswIndexProviderOpenError, HnswIndexRef,
 };
-use chroma_index::{HnswIndexConfig, Index, IndexConfig, IndexUuid};
-use chroma_index::{DEFAULT_HNSW_EF_CONSTRUCTION, DEFAULT_HNSW_EF_SEARCH, DEFAULT_HNSW_M};
+use chroma_index::{Index, IndexUuid};
 use chroma_types::SegmentUuid;
-use chroma_types::{get_metadata_value_as, MaterializedLogOperation, MetadataValue, Segment};
+use chroma_types::{MaterializedLogOperation, Segment};
 use std::collections::HashMap;
 use std::fmt::Debug;
 use thiserror::Error;

rust/worker/src/segment/spann_segment.rs

@@ -1,6 +1,3 @@
-use std::collections::HashMap;
-
-use arrow::error;
 use chroma_blockstore::provider::BlockfileProvider;
 use chroma_error::{ChromaError, ErrorCodes};
 use chroma_index::{hnsw_provider::HnswIndexProvider, spann::types::SpannIndexWriter, IndexUuid};
@@ -10,10 +7,14 @@ use uuid::Uuid;
 
 use super::utils::{distance_function_from_segment, hnsw_params_from_segment};
 
+#[allow(dead_code)]
 const HNSW_PATH: &str = "hnsw_path";
+#[allow(dead_code)]
 const VERSION_MAP_PATH: &str = "version_map_path";
+#[allow(dead_code)]
 const POSTING_LIST_PATH: &str = "posting_list_path";
 
+#[allow(dead_code)]
 pub(crate) struct SpannSegmentWriter {
     index: SpannIndexWriter,
     id: SegmentUuid,
@@ -52,6 +53,7 @@ impl ChromaError for SpannSegmentWriterError {
 }
 
 impl SpannSegmentWriter {
+    #[allow(dead_code)]
     pub async fn from_segment(
         segment: &Segment,
         blockfile_provider: &BlockfileProvider,
@@ -63,7 +65,7 @@ impl SpannSegmentWriter {
         }
         let distance_function = match distance_function_from_segment(segment) {
             Ok(distance_function) => distance_function,
-            Err(e) => {
+            Err(_) => {
                 return Err(SpannSegmentWriterError::DistanceFunctionNotFound);
             }
         };