This repository has been archived by the owner on May 17, 2021. It is now read-only.
Fixed logout #24
Open
Fixed logout #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrodriguez
reviewed
Mar 22, 2017
| @@ -1,3 +1,5 @@ | |||
| _this fork is onelogin modifications of:_ | |||
There was a problem hiding this comment.
This comment shall be removed
chrodriguez
reviewed
Mar 22, 2017
| @@ -0,0 +1,6 @@ | |||
| RedmineApp::Application.routes.draw do | |||
There was a problem hiding this comment.
This file should not be included
chrodriguez
reviewed
Mar 22, 2017
| user = self.find_by_login(user_attributes[:login]) | ||
| unless user | ||
| user = EmailAddress.find_by(address: user_attributes[:mail]).try(:user) | ||
| if user.nil? && Redmine::OmniAuthSAML.onthefly_creation? | ||
| user = new user_attributes | ||
| user = User.new(:status => 1, :language => Setting.default_language) |
There was a problem hiding this comment.
I think the code can be changed to:
new user_attributes.merge(:status => 1, :language => Setting.default_language)
chrodriguez
reviewed
Mar 22, 2017
| user = new user_attributes | ||
| user = User.new(:status => 1, :language => Setting.default_language) | ||
| # user = new user_attributes | ||
| user.mail = user_attributes[:mail] |
There was a problem hiding this comment.
this code is useless because of previous suggested (or original) initialization
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logout wasn't working, when redmine is accessed again, user was automatically logged in.