Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: factor out remove-react-images for lightgallery #270

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

chrisvogt
Copy link
Owner

@chrisvogt chrisvogt commented Dec 8, 2024

This PR swaps out react-images with lightgallery. The former dependency has a README that says, "Don't use this in a new project. This package hasn't been properly maintained in a long time and there are much better options available."

Copy link

netlify bot commented Dec 8, 2024

Deploy Preview for chrisvogt ready!

Name Link
🔨 Latest commit 8688374
🔍 Latest deploy log https://app.netlify.com/sites/chrisvogt/deploys/6755769a1a0ec00008f6875d
😎 Deploy Preview https://deploy-preview-270--chrisvogt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.05%. Comparing base (c7ac831) to head (8688374).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #270   +/-   ##
=======================================
  Coverage   94.05%   94.05%           
=======================================
  Files          64       64           
  Lines         656      656           
  Branches      188      188           
=======================================
  Hits          617      617           
  Misses         34       34           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisvogt
Copy link
Owner Author

The deploy preview looks good. I'm going to merge this. 🚀

Screenshot 2024-12-08 at 2 43 50 AM

@chrisvogt chrisvogt merged commit 249c71f into main Dec 8, 2024
10 checks passed
@chrisvogt chrisvogt deleted the remove-react-images branch December 8, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant