Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: animated background gradient broken by #256 #258

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

chrisvogt
Copy link
Owner

@chrisvogt chrisvogt commented Dec 3, 2024

In #256 I refactored how circles are created in animated-background.js, but forgot to update all instances of a method to use the new changes. This PR fixes that.

Before After
before after

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for chrisvogt ready!

Name Link
🔨 Latest commit aec59d3
🔍 Latest deploy log https://app.netlify.com/sites/chrisvogt/deploys/674e812819ee3e0008837acc
😎 Deploy Preview https://deploy-preview-258--chrisvogt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.07%. Comparing base (7904d72) to head (aec59d3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
+ Coverage   90.92%   91.07%   +0.15%     
==========================================
  Files          67       67              
  Lines         650      650              
  Branches      182      182              
==========================================
+ Hits          591      592       +1     
+ Misses         52       51       -1     
  Partials        7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisvogt
Copy link
Owner Author

Things are looking good in the deploy preview link. I'm going to merge this. 🚀

Screenshot 2024-12-02 at 7 58 00 PM

@chrisvogt chrisvogt merged commit 327b652 into main Dec 3, 2024
10 checks passed
@chrisvogt chrisvogt deleted the fix-bg-animation branch December 3, 2024 03:58
@chrisvogt chrisvogt restored the fix-bg-animation branch December 3, 2024 03:58
@chrisvogt chrisvogt deleted the fix-bg-animation branch December 3, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant