Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NotFoundError logging to JS console in Production #252

Merged
merged 2 commits into from
Nov 30, 2024

Conversation

chrisvogt
Copy link
Owner

@chrisvogt chrisvogt commented Nov 30, 2024

This PR fixes an issue with Emotion that has been logging to the console in Production for some time.

Screenshot 2024-11-30 at 12 19 54 PM
Before After
before after

Copy link

netlify bot commented Nov 30, 2024

Deploy Preview for chrisvogt ready!

Name Link
🔨 Latest commit 4a769d2
🔍 Latest deploy log https://app.netlify.com/sites/chrisvogt/deploys/674b78a3d296f00008a98748
😎 Deploy Preview https://deploy-preview-252--chrisvogt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.30%. Comparing base (98919d6) to head (4a769d2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #252      +/-   ##
==========================================
+ Coverage   90.15%   90.30%   +0.15%     
==========================================
  Files          67       67              
  Lines         650      650              
  Branches      179      179              
==========================================
+ Hits          586      587       +1     
+ Misses         56       55       -1     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisvogt chrisvogt changed the title chore: test removing new relic to fix a Prod warning log fix: NotFoundError logging to JS console in Production Nov 30, 2024
@chrisvogt chrisvogt self-assigned this Nov 30, 2024
@chrisvogt chrisvogt added the bug Something isn't working label Nov 30, 2024
@chrisvogt chrisvogt merged commit a6edeec into main Nov 30, 2024
10 checks passed
@chrisvogt chrisvogt deleted the remove-newrelic branch November 30, 2024 20:46
@chrisvogt
Copy link
Owner Author

Verified in Production after deployment: the logs are now error free.

Screenshot 2024-11-30 at 12 53 47 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant