Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a skip nav link to improve keyboard navigation #212

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chrisvogt
Copy link
Owner

This PR adds a skip nav link using @reach/skip-nav to improve keyboard navigation. As you navigate between pages, it's cumbersome to TAB through the header links every page. After this change, a new button appears at the top of the page if when you first begin to TAB through the content, allowing you to jump to the main content area.

Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for chrisvogt ready!

Name Link
🔨 Latest commit a64a53c
🔍 Latest deploy log https://app.netlify.com/sites/chrisvogt/deploys/66a1a9cd131c200008e37e52
😎 Deploy Preview https://deploy-preview-212--chrisvogt.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chrisvogt
Copy link
Owner Author

I'm holding off on merging this because it's not consistently working as expected: a large number of times it doesn't skip focus and just scrolls to the main content element.

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.46%. Comparing base (2a2a233) to head (a64a53c).
Report is 15 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #212   +/-   ##
=======================================
  Coverage   76.46%   76.46%           
=======================================
  Files          66       66           
  Lines         667      667           
  Branches      167      167           
=======================================
  Hits          510      510           
  Misses        143      143           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisvogt chrisvogt self-assigned this Sep 7, 2024
@chrisvogt chrisvogt added the accessibility Improves site accessibility label Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Improves site accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant