-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mac sparkle #190
Open
christofmuc
wants to merge
25
commits into
master
Choose a base branch
from
macSparkle
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Mac sparkle #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…modules, because building them on github is unstable (at least winsparkle). Adding in conan as a package manager now.
… from the github action script. For this, we use find package now instead of hard coding the paths into the third_party subdirectory. Also, bumping version number.
…ckage in the cache?
…the PYTHON_EXECUTABLE?
…ppear multiple times in the DMG created.
…ory, else it doesn't make sense.
…st compiles and runs on my local machine. Now I need to fix the DMG generation, which seems to be broken for a while now.
# Conflicts: # .github/workflows/builds-macos.yml # .github/workflows/builds-windows.yml # .gitmodules # CMakeLists.txt # The-Orm/CMakeLists.txt # third_party/sentry-native
…ly old from Feb 22, and there are changes in there that are no longer desired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.