Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Build workflow #567

Merged
merged 11 commits into from
Dec 17, 2024
Merged

Fix Build workflow #567

merged 11 commits into from
Dec 17, 2024

Conversation

christianhelle
Copy link
Owner

@christianhelle christianhelle commented Dec 17, 2024

This pull request includes several changes across different files to update the build environment, remove a package reference, and improve code robustness. The most important changes include switching the build environment to Windows, removing a specific package reference, and adding null-forgiving operators to avoid potential null reference issues.

Build environment update:

  • .github/workflows/build.yml: Changed the build environment to run on windows-latest instead of ubuntu-latest and added a step to set up .NET 9.0.

Package reference removal:

Code robustness improvements:

  • src/Refitter.Tests/SerializerTests.cs: Added null-forgiving operators to CodeGeneratorSettings.PropertyNameGenerator in the Can_Deserialize_RefitGeneratorSettingsWithoutNameGenerators and Deserialize_Is_Case_Insensitive methods to prevent potential null reference exceptions. [1] [2]

@christianhelle christianhelle added the github_actions Pull requests that update GitHub Actions code label Dec 17, 2024
@christianhelle christianhelle self-assigned this Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.93%. Comparing base (91a5544) to head (44a6a23).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #567   +/-   ##
=======================================
  Coverage   98.93%   98.93%           
=======================================
  Files          53       53           
  Lines        2541     2541           
=======================================
  Hits         2514     2514           
  Misses          4        4           
  Partials       23       23           
Flag Coverage Δ
unittests 98.93% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christianhelle christianhelle merged commit 024707a into main Dec 17, 2024
10 checks passed
@christianhelle christianhelle deleted the fix-build branch December 17, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant