-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Build workflow #567
Fix Build workflow #567
Conversation
…ator on CodeGeneratorSettings
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #567 +/- ##
=======================================
Coverage 98.93% 98.93%
=======================================
Files 53 53
Lines 2541 2541
=======================================
Hits 2514 2514
Misses 4 4
Partials 23 23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This pull request includes several changes across different files to update the build environment, remove a package reference, and improve code robustness. The most important changes include switching the build environment to Windows, removing a specific package reference, and adding null-forgiving operators to avoid potential null reference issues.
Build environment update:
.github/workflows/build.yml
: Changed the build environment to run onwindows-latest
instead ofubuntu-latest
and added a step to set up .NET 9.0.Package reference removal:
src/Refitter.SourceGenerator/Refitter.SourceGenerator.csproj
: Removed theMicrosoft.CodeAnalysis.CSharp
package reference.Code robustness improvements:
src/Refitter.Tests/SerializerTests.cs
: Added null-forgiving operators toCodeGeneratorSettings.PropertyNameGenerator
in theCan_Deserialize_RefitGeneratorSettingsWithoutNameGenerators
andDeserialize_Is_Case_Insensitive
methods to prevent potential null reference exceptions. [1] [2]