Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for custom relative output path in .refitter #172

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

Noblix
Copy link
Contributor

@Noblix Noblix commented Oct 3, 2023

This change allows for a relative output path to be specified in the .refitter config files similar to the --output option available in the CLI tool.

Example:

{
  "openApiPath": "../Resources/V3/SwaggerPetstore.json",
  "namespace": "Refitter.Tests.CustomGenerated",
  "output": "../CustomGenerated"
}

@christianhelle christianhelle self-assigned this Oct 3, 2023
@christianhelle christianhelle added the enhancement New feature, bug fix, or request label Oct 3, 2023
@christianhelle
Copy link
Owner

@Noblix thanks for this contribution

Can I ask you to update the README files with brief descriptions of the newly introduced output setting?

@christianhelle
Copy link
Owner

@all-contributors please add @Noblix for code

@allcontributors
Copy link
Contributor

@christianhelle

I've put up a pull request to add @Noblix! 🎉

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #172 (80054be) into main (c54dc5b) will not change coverage.
Report is 5 commits behind head on main.
The diff coverage is n/a.

❗ Current head 80054be differs from pull request most recent head 65e742f. Consider uploading reports for the commit 65e742f to get more accurate results

@@           Coverage Diff           @@
##             main     #172   +/-   ##
=======================================
  Coverage   98.37%   98.37%           
=======================================
  Files          41       41           
  Lines        1353     1353           
=======================================
  Hits         1331     1331           
  Misses          6        6           
  Partials       16       16           
Flag Coverage Δ
unittests 98.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@christianhelle
Copy link
Owner

@Noblix actually, let's just get this in and I'll fix the minor details myself

@christianhelle christianhelle merged commit 54a9b90 into christianhelle:main Oct 3, 2023
@christianhelle
Copy link
Owner

This contribution is now released in v0.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, bug fix, or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants