Merge pull request #550 from christianhelle/msbuild

Add support for disabling telemetry from MSBuild task
christianhelle · Dec 8, 2024 · 87d396c · 87d396c
2 parents d1cbaff + 4e88391
commit 87d396c
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 5 deletions.
diff --git a/src/Refitter.MSBuild/Refitter.MSBuild.targets b/src/Refitter.MSBuild/Refitter.MSBuild.targets
@@ -1,7 +1,8 @@
 <Project>
 
     <Target Name="Refitter" BeforeTargets="BeforeBuild">
-        <RefitterGenerateTask ProjectFileDirectory="$(MSBuildProjectDirectory)" />
+        <RefitterGenerateTask ProjectFileDirectory="$(MSBuildProjectDirectory)"
+                              DisableLogging="$(RefitterNoLogging)"/>
         <ItemGroup>
             <Compile Include="**/*.cs" />
         </ItemGroup>

diff --git a/src/Refitter.MSBuild/RefitterGenerateTask.cs b/src/Refitter.MSBuild/RefitterGenerateTask.cs
@@ -8,6 +8,8 @@ public class RefitterGenerateTask : MSBuildTask
 {
     public string ProjectFileDirectory { get; set; }
 
+    public bool DisableLogging { get; set; }
+
     public override bool Execute()
     {
         TryLogCommandLine($"Starting {nameof(RefitterGenerateTask)}");
@@ -47,14 +49,21 @@ private void StartProcess(string file)
         var packageFolder = Path.GetDirectoryName(assembly.Location);
         var seperator = Path.DirectorySeparatorChar;
         var refitterDll = $"{packageFolder}{seperator}..{seperator}refitter.dll";
-        TryLogCommandLine("Starting " + refitterDll);
+
+        var args = $"{refitterDll} --settings-file {file}";
+        if (DisableLogging)
+        {
+            args += " --no-logging";
+        }
+
+        TryLogCommandLine($"Starting dotnet {args}");
 
         using var process = new Process
         {
             StartInfo = new ProcessStartInfo
             {
                 FileName = "dotnet",
-                Arguments = $"{refitterDll} --settings-file {file}",
+                Arguments = args,
                 WorkingDirectory = Path.GetDirectoryName(file)!,
                 RedirectStandardOutput = true,
                 RedirectStandardError = true,

diff --git a/test/MSBuild/Refitter.MSBuild.Tests.csproj b/test/MSBuild/Refitter.MSBuild.Tests.csproj
@@ -1,10 +1,11 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
     <PropertyGroup>
         <OutputType>Exe</OutputType>
         <TargetFramework>net8.0</TargetFramework>
         <ImplicitUsings>enable</ImplicitUsings>
         <Nullable>enable</Nullable>
+        <RefitterNoLogging>true</RefitterNoLogging>
     </PropertyGroup>
 
     <ItemGroup>
@@ -13,5 +14,5 @@
         <PackageReference Include="Microsoft.Extensions.Http.Polly" Version="9.0.0" />
         <PackageReference Include="Polly.Contrib.WaitAndRetry" Version="1.1.1" />
     </ItemGroup>
-   
+
 </Project>