Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move a file to a new directory with its existing name, closes #35 #36

Merged

Conversation

stevenxxiu
Copy link
Contributor

@stevenxxiu stevenxxiu commented Dec 29, 2023

Checklist

  • Adhered to the stylua.toml.
  • Used only camelCase variable names.
  • If functionaltiy is added or modified, also made respective changes to the readme.
    • Functionality is modified, but the readme already says this behaves like mv.
  • Used conventional commits keywords.

@chrisgrieser
Copy link
Owner

thanks!

Could you nonetheless make it explicit in the readme, that you can use the moveRename command in that way? Not everyone is familiar with mv. (I, for instance, did not know that you can use mv that way. By "behaves like mv" I meant that moving is effectively the same thing as renaming)

@stevenxxiu stevenxxiu force-pushed the feat/move-with-existing-name branch from f352eb8 to 5fc6f03 Compare December 29, 2023 14:43
@stevenxxiu
Copy link
Contributor Author

stevenxxiu commented Dec 29, 2023

Sure thing, done. Btw there's a typo in "functionaltiy" in the GitHub PR template.

@stevenxxiu stevenxxiu force-pushed the feat/move-with-existing-name branch from 5fc6f03 to 4a28570 Compare December 29, 2023 14:46
@chrisgrieser chrisgrieser merged commit e221036 into chrisgrieser:main Dec 29, 2023
1 check passed
@chrisgrieser
Copy link
Owner

thx, merged & also typo fixed.

@stevenxxiu stevenxxiu deleted the feat/move-with-existing-name branch December 29, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants