-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show sound sources #1277
Show sound sources #1277
Conversation
Don't just skip 6 and hope for the best
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TR1, TR4 and TR5 look good to me. Classic TR2/3 both unfortunately crash as follows (but are fine when opening from a folder that doesn't have MAIN.SFX).
This doesn't happen if I open remastered files, so I assume it's a slight difference in the MAIN.SFX layout. I remember looking at this and put the hack below in place, but I promptly forgot about it as it's a rarely used utility.
https://github.com/LostArtefacts/TR-Rando/blob/master/SFXExport/Program.cs#L54
Maybe a slight improvement (possibly a future task) would be to show when the sound data is not present in the level file. ID 304 isn't in the sound map in this level, but with the sample showing 0 it's sort of implied that it should be Lara's footsteps. Maybe some sort of indicator would be good here. |
Ah thanks. Might be a bit of an issue emulating that |
If sample not present, indicate that. Load classic main.sfx correctly. Load psx sound details (not samples, can't find) #1270
Add sound sources to the viewer.
Add a sound sources window. Window also shows the sounds in the level (sound board) and allows user to play either a specific sound source sample or a sound from the board.
Attempts to load from MAIN.SFX if present in the same folder for TR2 and TR3.
Closes #1270