Allow user to change fonts #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loads fonts from registry
Will need to recalculate all the time - but can improve it.
Just have a context menu instead because the sizing is tricky.
Will manage loading fonts as safely as possible.
Handle failure to some degree
Also fix icon alignment #970
lahm86
reviewed
May 10, 2024
There was a problem hiding this comment.
Looks great. The only slight usability thing I could see was if you press and hold the +/- buttons for changing font size - because the window size changes, the buttons shift from under the mouse so you need to re-position to continue changing the value. Can the event be delayed until the mouse is released maybe? If not, I don't think it's a big deal to be honest.
lahm86
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the user to change the fonts used in the program. Current options are for:
More can be added later.
Fonts are now retrieved by key and not stored by consumers so they can be switched without consumer having to deal with that.
Windows are adjusted to better handle resizing. The main tables will adjust for font sizing. The
Xbutton to delete a save in a route waypoint has been removed and replaced with a right click context menu.Switches to using FreeType rendering for fonts as with the STB implementation loading some fonts would crash the application - the FreeType implementation lets us catch the errors a little better.
Closes #970