A few minor fixes for the phase-field model #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofiaangriman
approved these changes
May 1, 2024
|
Asymmetry in the velocity-coupled phase-field is fixed! This was only an issue in the recently added new direct forcing implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 minor fixes that make little impact but should be implemented for consistency:
cxphicshould be used instead ofcxsalcfor interpolating latent heat (these used to be identical in earlier versions)InterpTempMultigridwas only written for the case of Dirichlet BCs, now it's updated to work for Neumann BCs as well