Sw integrate queue with bot #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some gems could not be fetched over https. This is currently a stashed change on the instance but I can commit it here
The access and refresh tokens are too long to be stored as strings Also fixed some typos in the station names and env vars
When a spot opens the next person in line will be notified
jmangel
approved these changes
Mar 20, 2020
app/models/channel_queue.rb
Outdated
| @@ -17,6 +17,10 @@ def members_string | |||
| "```#{formatted_response}```" | |||
| end | |||
|
|
|||
| def first_user_in_line | |||
| channel_queue_memberships.order(created_at: :asc).joins(:user).first&.user | |||
There was a problem hiding this comment.
There is a NextInQueue service that's also used by the /queue open command, but it shouldn't be any different or more robust than this, afaik
The service already exists and contains similar logic so it should be reuseable. I also remembered that the &. operator doesn't work in rails 2 so I have to remove that anyways
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.