Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(doc) Update cmdlet docs for ShouldProcess support #1086

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

vexx32
Copy link
Member

@vexx32 vexx32 commented Oct 22, 2024

Description Of Changes

  • Update cmdlet docs with ShouldProcess parameters where they're supported

Motivation and Context

As we're adding this support into the CLI helper commands that have been rewritten, we need to update our documentation to reflect this as well.

Testing

  • I have previewed these changes using the Docker Container or another method before submitting this pull request.

Change Types Made

  • Minor documentation fix (typos etc.).
  • Major documentation change (refactoring, reformatting or adding documentation to existing page).
  • New documentation page added.
  • The change I have made should have a video added, and I have raised an issue for this.
    • Issue #

Change Checklist

  • Requires a change to menu structure (top or left-hand side)/
  • Menu structure has been updated

Related Issue

chocolatey/choco#3532

As we're adding this support into the CLI helper commands that have been
rewritten, we need to update our documentation to reflect this as well.
@gep13
Copy link
Member

gep13 commented Oct 25, 2024

Assuming that this goes out in the 2.4.0 release, we will need to remember to include this in the documentation that goes out at the same time. If/when that decision is made, can you add this PR into a documentation milestone, so that it doesn't get lost?

@vexx32 vexx32 requested a review from corbob November 5, 2024 14:47
@vexx32 vexx32 added this to the Chocolatey CLI v2.4.0 milestone Nov 5, 2024
@vexx32 vexx32 marked this pull request as ready for review November 5, 2024 21:26
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit caa8ab9 into chocolatey:master Nov 12, 2024
1 check passed
@gep13
Copy link
Member

gep13 commented Nov 12, 2024

@vexx32 thanks for getting this updated!

@vexx32 vexx32 deleted the shouldprocess branch November 12, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants