Support install msu

[zjkyz8]

msu is a windows hotfix file type. this file need wusa.exe to install, just like msi.

[gep13]

Hey,

Just a thought, if this is going to go ahead, I would suggest that the documentation at the top of the Install-ChocolateyInstallPackage.ps1 file should be updated to make it clear that it is not just msi and exe, but also for an msu.

Thoughts?

Gary

[ferventcoder]

I think we can accomodate this... the priorities might fall this to take some time. I see you've done this on your master branch. If you plan to make any more changes and do pull requests you would be limited.

My suggestion is that you close this, move the changes to a branch, and then issue the pull request. That would allow you to make any additional pull requests or update your branch without influencing this request.

Keep in mind the current wait time for acceptance of pull requests in chocolatey is on the order of a couple of months if not longer. Some things we get in very quickly, some things we do not, depending on where it falls for prioritization.

[rismoney]

also I would do a git rebase -i and fixup the second commit to make it look like one.

[ferventcoder]

I'm less concerned about the rebase... what I don't want you to do though is do a pull and merge, that messes with source. Then I have to cherry pick your commits out to keep a good linear history.

[rismoney]

yes. we should strive to keep a clean timeline moving forward. a couple of things here:

1. create new branch
2. cherry pick changes into new branch or checkout -b newbranch, and then git reset --hard his master.
3. rebase.
4. then the maintainers should not do a gui based merged. these are --no-ff and create a merge commit on top. This makes the graph bumpy. If we want a timeline that is easily bisectable we should try to get merges that are --ff and encourage small single commit continuous changes. also when we leverage the testing frameworks this will help us immensely.

[ferventcoder]

I have the methods I expect committers to use in an email somewhere - it might be a good idea to put it into a readme markdown in the source.. it's very close to what you are saying here Rich.

[ferventcoder]

Basically what should happen for the requestee:

1. git checkout -b support_msu
2. reissue pull request.
3. reset your master to remove these changes. git extensions gui is a helpful one for doing that.

[gep13]

I think that this would definitely make sense to be included in the wiki, "somewhere". I have on my todo list to do a complete write up of "How to contribute to the Chocolatey Project", i.e. fork the source code, create a branch, do your work, run the Pester Tests, Write new Pester Tests, commit code, do pull request etc, but again, never seem to get the cycles to do it.