Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added regex configuration to the interface name rule #2211

Merged
merged 4 commits into from
Aug 7, 2024

Conversation

sconwayaus
Copy link
Contributor

Adding regex configuration to the interface name style rule, part of issue #2074

@sconwayaus sconwayaus force-pushed the interface_name_style_regex branch 3 times, most recently from b12440f to 76ada02 Compare July 10, 2024 12:33
@sconwayaus sconwayaus force-pushed the interface_name_style_regex branch from 76ada02 to 43592ad Compare July 10, 2024 13:07
@hzeller
Copy link
Collaborator

hzeller commented Aug 5, 2024

Looks like there is a merge-conflict in one of the files, can you rebase ?

@sconwayaus sconwayaus force-pushed the interface_name_style_regex branch from 80131eb to 82f489c Compare August 6, 2024 12:32
@sconwayaus
Copy link
Contributor Author

Now mergable.

I also fixed up the konstants naming style.

@hzeller hzeller merged commit 8b64887 into chipsalliance:master Aug 7, 2024
34 checks passed
@hzeller
Copy link
Collaborator

hzeller commented Aug 7, 2024

Thanks, merged!

@sconwayaus sconwayaus deleted the interface_name_style_regex branch August 7, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants