C++20 preparation: make operator != non-ambiguous. #2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2024 +/- ##
=======================================
Coverage 92.85% 92.85%
=======================================
Files 357 357
Lines 26397 26397
=======================================
Hits 24510 24510
Misses 1887 1887 ☔ View full report in Codecov by Sentry. |
fangism
approved these changes
Oct 10, 2023
C++20 auto-generates the != operator from ==. However, if that operator accepts a potentiallly different type, this might result in an ambiguous operator (-Wambiguous-reversed-operator). This provides the explicitly defined operator. While at it: update expectations for smoke tests as pulled projects changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++20 auto-generates the != operator from ==. However, if that operator accepts a potentiallly different type, this might result in an ambiguous operator (-Wambiguous-reversed-operator). This provides the explicitly defined operator.