chipsalliance · hzeller · Sep 18, 2023 · Sep 18, 2023
diff --git a/.github/bin/smoke-test.sh b/.github/bin/smoke-test.sh
@@ -132,30 +132,30 @@ ExpectedFailCount[lint:ibex]=14
 ExpectedFailCount[project:ibex]=193
 ExpectedFailCount[preprocessor:ibex]=368
 
-ExpectedFailCount[syntax:opentitan]=36
-ExpectedFailCount[lint:opentitan]=36
-ExpectedFailCount[project:opentitan]=733
-ExpectedFailCount[preprocessor:opentitan]=1957
+ExpectedFailCount[syntax:opentitan]=35
+ExpectedFailCount[lint:opentitan]=35
+ExpectedFailCount[project:opentitan]=739
+ExpectedFailCount[preprocessor:opentitan]=1978
 
 ExpectedFailCount[syntax:sv-tests]=77
 ExpectedFailCount[lint:sv-tests]=76
 ExpectedFailCount[project:sv-tests]=187
 ExpectedFailCount[preprocessor:sv-tests]=139
 
-ExpectedFailCount[syntax:caliptra-rtl]=19
-ExpectedFailCount[lint:caliptra-rtl]=19
-ExpectedFailCount[project:caliptra-rtl]=315
-ExpectedFailCount[preprocessor:caliptra-rtl]=698
+ExpectedFailCount[syntax:caliptra-rtl]=21
+ExpectedFailCount[lint:caliptra-rtl]=21
+ExpectedFailCount[project:caliptra-rtl]=324
+ExpectedFailCount[preprocessor:caliptra-rtl]=758
 
 ExpectedFailCount[syntax:Cores-VeeR-EH2]=2
 ExpectedFailCount[lint:Cores-VeeR-EH2]=2
 ExpectedFailCount[project:Cores-VeeR-EH2]=42
 ExpectedFailCount[preprocessor:Cores-VeeR-EH2]=43
 
-ExpectedFailCount[syntax:cva6]=4
-ExpectedFailCount[lint:cva6]=4
-ExpectedFailCount[project:cva6]=69
-ExpectedFailCount[preprocessor:cva6]=65
+ExpectedFailCount[syntax:cva6]=5
+ExpectedFailCount[lint:cva6]=5
+ExpectedFailCount[project:cva6]=76
+ExpectedFailCount[preprocessor:cva6]=98
 
 ExpectedFailCount[syntax:uvm]=1
 ExpectedFailCount[lint:uvm]=1
@@ -175,10 +175,10 @@ ExpectedFailCount[lint:XilinxUnisimLibrary]=4
 ExpectedFailCount[project:XilinxUnisimLibrary]=22
 ExpectedFailCount[preprocessor:XilinxUnisimLibrary]=96
 
-ExpectedFailCount[syntax:black-parrot]=156
-ExpectedFailCount[lint:black-parrot]=156
-ExpectedFailCount[project:black-parrot]=171
-ExpectedFailCount[preprocessor:black-parrot]=172
+ExpectedFailCount[syntax:black-parrot]=155
+ExpectedFailCount[lint:black-parrot]=155
+ExpectedFailCount[project:black-parrot]=170
+ExpectedFailCount[preprocessor:black-parrot]=171
 
 ExpectedFailCount[syntax:ivtest]=166
 ExpectedFailCount[lint:ivtest]=166
@@ -190,8 +190,8 @@ ExpectedFailCount[lint:nontrivial-mips]=2
 ExpectedFailCount[project:nontrivial-mips]=81
 ExpectedFailCount[preprocessor:nontrivial-mips]=78
 
-ExpectedFailCount[project:axi]=73
-ExpectedFailCount[preprocessor:axi]=70
+ExpectedFailCount[project:axi]=74
+ExpectedFailCount[preprocessor:axi]=71
 
 ExpectedFailCount[syntax:rsd]=5
 ExpectedFailCount[lint:rsd]=5
@@ -207,7 +207,7 @@ ExpectedFailCount[preprocessor:serv]=1
 ExpectedFailCount[syntax:basejump_stl]=466
 ExpectedFailCount[lint:basejump_stl]=466
 ExpectedFailCount[project:basejump_stl]=577
-ExpectedFailCount[preprocessor:basejump_stl]=610
+ExpectedFailCount[preprocessor:basejump_stl]=611
 
 # Ideally, we expect all tools to process all files with a zero exit code.
 # However, that is not always the case, so we document the current

diff --git a/.github/workflows/verible-ci.yml b/.github/workflows/verible-ci.yml
@@ -507,10 +507,10 @@ jobs:
       run: bazel info
 
     - name: Run Tests
-      run: bazel test --noshow_progress --test_output=errors //...
+      run: bazel test --keep_going --noshow_progress --test_output=errors //...
 
     - name: Build Verible Binaries
-      run: bazel build --noshow_progress -c opt :install-binaries
+      run: bazel build --keep_going --noshow_progress -c opt :install-binaries
 
     - name: Prepare release
       run: |

diff --git a/common/analysis/citation.cc b/common/analysis/citation.cc
@@ -14,6 +14,8 @@
 
 #include "common/analysis/citation.h"
 
+#include <string>
+
 #include "absl/strings/str_cat.h"
 
 namespace verible {

diff --git a/common/analysis/command_file_lexer.cc b/common/analysis/command_file_lexer.cc
@@ -14,6 +14,9 @@
 
 #include "common/analysis/command_file_lexer.h"
 
+#include <algorithm>
+#include <vector>
+
 #include "absl/strings/string_view.h"
 #include "common/analysis/lint_waiver.h"
 #include "common/lexer/token_stream_adapter.h"

diff --git a/common/analysis/command_file_lexer.h b/common/analysis/command_file_lexer.h
@@ -27,6 +27,8 @@
 #  undef yyFlexLexer  // this is how FlexLexer.h says to do things
 #  define yyFlexLexer veribleCommandFileFlexLexer
 #  include <FlexLexer.h>
+
+#include <vector>
 #endif
 // clang-format on
 

diff --git a/common/analysis/file_analyzer.cc b/common/analysis/file_analyzer.cc
@@ -17,6 +17,7 @@
 #include "common/analysis/file_analyzer.h"
 
 #include <algorithm>
+#include <ostream>
 #include <sstream>  // IWYU pragma: keep  // for ostringstream
 #include <string>
 #include <vector>

diff --git a/common/analysis/file_analyzer.h b/common/analysis/file_analyzer.h
@@ -41,7 +41,9 @@
 
 #include <functional>
 #include <iosfwd>
+#include <memory>
 #include <string>
+#include <utility>
 #include <vector>
 
 #include "absl/status/status.h"

diff --git a/common/analysis/line_linter_test.cc b/common/analysis/line_linter_test.cc
@@ -16,6 +16,7 @@
 
 #include <cstddef>
 #include <memory>
+#include <set>
 #include <vector>
 
 #include "absl/strings/string_view.h"

diff --git a/common/analysis/lint_rule_status.cc b/common/analysis/lint_rule_status.cc
@@ -19,6 +19,7 @@
 #include <iostream>
 #include <iterator>
 #include <ostream>
+#include <set>
 #include <string>
 #include <vector>
 

diff --git a/common/analysis/lint_rule_status_test.cc b/common/analysis/lint_rule_status_test.cc
@@ -14,8 +14,11 @@
 
 #include "common/analysis/lint_rule_status.h"
 
+#include <iostream>
+#include <set>
 #include <sstream>  // IWYU pragma: keep  // for ostringstream
 #include <string>
+#include <utility>
 #include <vector>
 
 #include "absl/strings/str_split.h"

diff --git a/common/analysis/lint_waiver.cc b/common/analysis/lint_waiver.cc
@@ -22,6 +22,7 @@
 #include <map>
 #include <regex>  // NOLINT
 #include <set>
+#include <string>
 #include <utility>
 #include <vector>
 

diff --git a/common/analysis/lint_waiver.h b/common/analysis/lint_waiver.h
@@ -19,6 +19,8 @@
 #include <map>
 #include <regex>  // NOLINT
 #include <set>
+#include <string>
+#include <utility>
 #include <vector>
 
 #include "absl/strings/string_view.h"

diff --git a/common/analysis/lint_waiver_test.cc b/common/analysis/lint_waiver_test.cc
@@ -15,6 +15,7 @@
 #include "common/analysis/lint_waiver.h"
 
 #include <cstddef>
+#include <set>
 #include <vector>
 
 #include "common/strings/line_column_map.h"

diff --git a/common/analysis/linter_test_utils.cc b/common/analysis/linter_test_utils.cc
@@ -16,6 +16,7 @@
 
 #include <iostream>
 #include <iterator>
+#include <set>
 #include <vector>
 
 #include "absl/strings/string_view.h"

diff --git a/common/analysis/linter_test_utils.h b/common/analysis/linter_test_utils.h
@@ -21,6 +21,7 @@
 #include <memory>
 #include <set>
 #include <sstream>
+#include <string>
 
 #include "absl/status/status.h"
 #include "absl/strings/str_cat.h"

diff --git a/common/analysis/linter_test_utils_test.cc b/common/analysis/linter_test_utils_test.cc
@@ -14,6 +14,7 @@
 
 #include "common/analysis/linter_test_utils.h"
 
+#include <set>
 #include <sstream>
 #include <string>
 #include <vector>

diff --git a/common/analysis/syntax_tree_linter_test.cc b/common/analysis/syntax_tree_linter_test.cc
@@ -15,6 +15,7 @@
 #include "common/analysis/syntax_tree_linter.h"
 
 #include <memory>
+#include <set>
 #include <vector>
 
 #include "common/analysis/lint_rule_status.h"

diff --git a/common/analysis/text_structure_linter_test.cc b/common/analysis/text_structure_linter_test.cc
@@ -15,6 +15,7 @@
 #include "common/analysis/text_structure_linter.h"
 
 #include <memory>
+#include <set>
 #include <vector>
 
 #include "absl/strings/match.h"

diff --git a/common/analysis/token_stream_linter_test.cc b/common/analysis/token_stream_linter_test.cc
@@ -15,6 +15,7 @@
 #include "common/analysis/token_stream_linter.h"
 
 #include <memory>
+#include <set>
 #include <vector>
 
 #include "absl/strings/string_view.h"

diff --git a/common/analysis/violation_handler.cc b/common/analysis/violation_handler.cc
@@ -14,6 +14,13 @@
 
 #include "common/analysis/violation_handler.h"
 
+#include <iostream>
+#include <ostream>
+#include <set>
+#include <sstream>
+#include <string>
+#include <vector>
+
 #include "absl/status/status.h"
 #include "common/strings/diff.h"
 #include "common/util/file_util.h"

diff --git a/common/formatting/align.cc b/common/formatting/align.cc
@@ -15,11 +15,17 @@
 #include "common/formatting/align.h"
 
 #include <algorithm>
+#include <cstddef>
+#include <cstdlib>
 #include <functional>
 #include <iostream>
 #include <iterator>
+#include <limits>
 #include <map>
 #include <numeric>
+#include <sstream>
+#include <string>
+#include <utility>
 #include <vector>
 
 #include "absl/strings/str_join.h"

diff --git a/common/formatting/align.h b/common/formatting/align.h
@@ -16,6 +16,8 @@
 #define VERIBLE_COMMON_FORMATTING_ALIGN_H_
 
 #include <functional>
+#include <ostream>
+#include <string>
 #include <vector>
 
 #include "absl/strings/string_view.h"

diff --git a/common/formatting/align_test.cc b/common/formatting/align_test.cc
@@ -14,6 +14,9 @@
 
 #include "common/formatting/align.h"
 
+#include <algorithm>
+#include <iterator>
+#include <ostream>
 #include <sstream>
 #include <string>
 #include <utility>

diff --git a/common/formatting/format_token.cc b/common/formatting/format_token.cc
@@ -14,9 +14,12 @@
 
 #include "common/formatting/format_token.h"
 
+#include <algorithm>
 #include <iostream>
 #include <sstream>  // pragma IWYU: keep  // for ostringstream
 #include <string>
+#include <utility>
+#include <vector>
 
 #include "absl/base/macros.h"
 #include "absl/strings/string_view.h"

diff --git a/common/formatting/layout_optimizer.cc b/common/formatting/layout_optimizer.cc
@@ -20,8 +20,12 @@
 #include "common/formatting/layout_optimizer.h"
 
 #include <algorithm>
+#include <cmath>
 #include <iomanip>
+#include <ios>
+#include <limits>
 #include <ostream>
+#include <utility>
 
 #include "absl/container/fixed_array.h"
 #include "common/formatting/basic_format_style.h"

diff --git a/common/formatting/layout_optimizer_internal.h b/common/formatting/layout_optimizer_internal.h
@@ -18,9 +18,12 @@
 #define VERIBLE_VERILOG_FORMATTING_LAYOUT_OPTIMIZER_INTERNAL_H_
 
 #include <algorithm>
+#include <cstddef>
 #include <iterator>
 #include <ostream>
+#include <string>
 #include <type_traits>
+#include <utility>
 #include <vector>
 
 #include "absl/container/fixed_array.h"

diff --git a/common/formatting/layout_optimizer_test.cc b/common/formatting/layout_optimizer_test.cc
@@ -14,6 +14,9 @@
 //
 #include "common/formatting/layout_optimizer.h"
 
+#include <algorithm>
+#include <limits>
+#include <ostream>
 #include <sstream>
 #include <string>
 #include <vector>

diff --git a/common/formatting/line_wrap_searcher.cc b/common/formatting/line_wrap_searcher.cc
@@ -15,6 +15,7 @@
 #include "common/formatting/line_wrap_searcher.h"
 
 #include <memory>
+#include <ostream>
 #include <queue>
 #include <vector>
 

diff --git a/common/formatting/line_wrap_searcher_test.cc b/common/formatting/line_wrap_searcher_test.cc
@@ -14,6 +14,7 @@
 
 #include "common/formatting/line_wrap_searcher.h"
 
+#include <sstream>
 #include <vector>
 
 #include "absl/strings/match.h"

diff --git a/common/formatting/state_node.cc b/common/formatting/state_node.cc
@@ -17,6 +17,7 @@
 #include <cstddef>
 #include <iterator>
 #include <memory>
+#include <ostream>
 #include <stack>
 #include <vector>
 

diff --git a/common/formatting/state_node_test.cc b/common/formatting/state_node_test.cc
@@ -15,6 +15,7 @@
 #include "common/formatting/state_node.h"
 
 #include <memory>
+#include <sstream>
 #include <stack>
 #include <string>
 #include <vector>

diff --git a/common/formatting/token_partition_tree.cc b/common/formatting/token_partition_tree.cc
@@ -14,8 +14,12 @@
 
 #include "common/formatting/token_partition_tree.h"
 
+#include <algorithm>
 #include <cstddef>
 #include <iterator>
+#include <memory>
+#include <ostream>
+#include <utility>
 #include <vector>
 
 #include "common/formatting/format_token.h"

diff --git a/common/formatting/tree_annotator.cc b/common/formatting/tree_annotator.cc
@@ -14,6 +14,7 @@
 
 #include "common/formatting/tree_annotator.h"
 
+#include <iterator>
 #include <vector>
 
 #include "common/text/concrete_syntax_leaf.h"

diff --git a/common/formatting/tree_annotator_test.cc b/common/formatting/tree_annotator_test.cc
@@ -14,6 +14,8 @@
 
 #include "common/formatting/tree_annotator.h"
 
+#include <vector>
+
 #include "common/formatting/format_token.h"
 #include "common/text/constants.h"
 #include "common/text/token_info.h"