Skip to content

Commit

Permalink
Merge pull request #820 from hzeller/use-latest-gflags
Browse files Browse the repository at this point in the history
Use latest gflags, which does not produce a fallthrough-warning.
  • Loading branch information
hzeller authored May 19, 2021
2 parents 51d3702 + d3a7440 commit 8f5a325
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
4 changes: 3 additions & 1 deletion .github/bin/build-and-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ BAZEL_OPTS="${BAZEL_OPTS} --cxxopt=-Wall --cxxopt=-Wextra"
BAZEL_OPTS="${BAZEL_OPTS} --cxxopt=-Wno-unused-parameter"
BAZEL_OPTS="${BAZEL_OPTS} --cxxopt=-Wno-missing-field-initializers"

# Currently there is a break missing introduced in #802
BAZEL_OPTS="${BAZEL_OPTS} --cxxopt=-Wno-implicit-fallthrough"

# Warnings in our code-base, that we might consider removing.
BAZEL_OPTS="${BAZEL_OPTS} --cxxopt=-Wno-redundant-move"

Expand All @@ -45,7 +48,6 @@ BAZEL_OPTS="${BAZEL_OPTS} --cxxopt=-Wno-array-bounds"
# tight warnings on for 'our' code-base.
# TODO(hzeller): Remove after https://github.com/google/verible/issues/747
# is figure out
BAZEL_OPTS="${BAZEL_OPTS} --cxxopt=-Wno-implicit-fallthrough" # gflags
BAZEL_OPTS="${BAZEL_OPTS} --cxxopt=-Wno-cast-function-type" # gflags
BAZEL_OPTS="${BAZEL_OPTS} --cxxopt=-Wno-deprecated-declarations" # jsconcpp

Expand Down
6 changes: 3 additions & 3 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ http_archive(
# extra dependency.
http_archive(
name = "com_github_gflags_gflags",
sha256 = "34af2f15cf7367513b352bdcd2493ab14ce43692d2dcd9dfc499492966c64dcf",
strip_prefix = "gflags-2.2.2",
urls = ["https://github.com/gflags/gflags/archive/v2.2.2.tar.gz"],
sha256 = "cfdba0f2f17e8b1ff75c98113d5080d8ec016148426abcc19130864e2952d7bd",
strip_prefix = "gflags-827c769e5fc98e0f2a34c47cef953cc6328abced",
urls = ["https://github.com/gflags/gflags/archive/827c769e5fc98e0f2a34c47cef953cc6328abced.zip" ],
)

http_archive(
Expand Down

0 comments on commit 8f5a325

Please sign in to comment.