Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to Surelog API change #2135

Merged

Conversation

alaindargelas
Copy link
Collaborator

No description provided.

@kgugala
Copy link
Member

kgugala commented Nov 15, 2023

does this really do anything with signed/unsigned? looking at the changes it seems to be only adapting the code for Surelog API changes

@alaindargelas
Copy link
Collaborator Author

The real change is in Surelog, critical warning and propagation of signage

@kgugala kgugala changed the title Signed vs unsigned port conn Adapt to Surelog API change Nov 15, 2023
@kgugala kgugala merged commit e520639 into chipsalliance:main Nov 15, 2023
32 checks passed
@hzeller
Copy link
Collaborator

hzeller commented Nov 16, 2023

Would it be good to also update the Synlig version to match the Surelog/UHDM versions it is compatible with ?

@alain-rs
Copy link

The cmake build does that. But this merge happened out of order.
The stable_rs branch is up to date with versions

@alaindargelas alaindargelas deleted the signed_vs_unsigned_port_conn branch January 11, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants