Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove VeeR asserts from simulation builds #4943

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Remove VeeR asserts from simulation builds #4943

merged 2 commits into from
Sep 5, 2023

Conversation

robertszczepanski
Copy link
Contributor

Fixes #4941.

@robertszczepanski robertszczepanski changed the title [WIP] Remove VeeR asserts from simulation builds Remove VeeR asserts from simulation builds Sep 4, 2023
@robertszczepanski robertszczepanski marked this pull request as ready for review September 4, 2023 14:17
@robertszczepanski robertszczepanski marked this pull request as draft September 4, 2023 14:21
@robertszczepanski robertszczepanski marked this pull request as ready for review September 4, 2023 15:18
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Changes In Tests

Tool New Failures New Passes Added Removed Not Affected
UhdmVerilator 0 0 0 0 4686
UhdmYosys 0 0 0 0 4671
Surelog 0 0 0 0 4671
moore_parse 0 0 0 0 4517
Slang 0 1 0 0 4670
Verible 0 0 0 0 4517
tree_sitter_verilog 0 0 0 0 4517
moore 0 0 0 0 4608
Odin 0 0 0 0 4608
sv_parser 0 0 0 0 4608
Verilator 0 1 0 0 4685
Sv2v_zachjs 0 0 0 0 4671
Icarus 0 0 0 0 4686
Slang_parse 0 0 0 0 4608
Yosys 0 1 0 0 4670
VeribleExtractor 0 0 0 0 4517

Download an archive containing all the details

tmichalak
tmichalak approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@tmichalak tmichalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmichalak tmichalak merged commit 4473791 into chipsalliance:master Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmichalak tmichalak tmichalak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Veer-EL2 with Verilator
2 participants
@robertszczepanski @tmichalak