Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support either rational direction for rocket rational CDCs #3693

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Support either rational direction for rocket rational CDCs #3693

merged 1 commit into from
Oct 30, 2024

Conversation

jerryz123
Copy link
Contributor

Related issue:

Type of change: bug report | feature request | other enhancement

Impact: no functional change | API addition (no impact on existing code) | API modification

Development Phase: proposal | implementation

Release Notes

@jerryz123 jerryz123 requested a review from sequencer October 30, 2024 17:40
lordspacehog
lordspacehog approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@lordspacehog lordspacehog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerryz123 jerryz123 changed the base branch from master to dev October 30, 2024 17:43
sequencer
sequencer approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@sequencer sequencer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should think about how to generate the clock metadata in the future diplomacy2… and cut the line for CDC with snps blackboxes.

@jerryz123 jerryz123 mentioned this pull request Oct 30, 2024
Closed
3 tasks
@jerryz123 jerryz123 merged commit ea7bb3a into dev Oct 30, 2024
28 checks passed
@jerryz123 jerryz123 deleted the rocket-rational-cdcs branch October 30, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sequencer sequencer sequencer approved these changes

@lordspacehog lordspacehog lordspacehog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerryz123 @lordspacehog @sequencer