Change default layers to use lowercase directories #4505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change directories for default layers to use lowercase output directories. While this is independently likely a better choice, it is a somewhat pragmatic, as these directory names match the legacy names of `firtool`'s extract-test-code feature (which was a custom SiFive pass for the SFC before being open-sourced in `firtool`). This will help us land an extract-test-code replacement without having to disturb build flows. Secondarily, and independently, lower case directories are likely better. There are two alternative changes which were rejected: 1. The layers could be renamed to be lowercase. Generally, it's better to have objects and classes be uppercase. 2. The automatic directory names could be mangled to be lowercase as opposed to the exact layer names. Signed-off-by: Schuyler Eldridge <[email protected]>
seldridge
added
API Modification
Backend Code Generation
jackkoenig
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change directories for default layers to use lowercase output directories. While this is independently likely a better choice, it is a somewhat pragmatic, as these directory names match the legacy names of
firtool's extract-test-code feature (which was a custom SiFive pass for the SFC before being open-sourced infirtool). This will help us land an extract-test-code replacement without having to disturb build flows. Secondarily, and independently, lower case directories are likely better.There are two alternative changes which were rejected:
The layers could be renamed to be lowercase. Generally, it's better to have objects and classes be uppercase.
The automatic directory names could be mangled to be lowercase as opposed to the exact layer names.
Release Notes
Change directories for default layers to be lowercase.